Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding circuit breakers on ingester server side for write path #8180

Merged
merged 16 commits into from
Jun 4, 2024
Merged

Adding circuit breakers on ingester server side for write path #8180

merged 16 commits into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. Adding circuit breakers on ingester server side for write path 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    661df87 View commit details
    Browse the repository at this point in the history

  2. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3a8279d View commit details
    Browse the repository at this point in the history

  3. Fixing review findigs 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    186bc2b View commit details
    Browse the repository at this point in the history

  4. Implementing the gauge as NewGaugeFunc

    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    020db98 View commit details
    Browse the repository at this point in the history

  5. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ece7eeb View commit details
    Browse the repository at this point in the history

  6. Fixing lint issues 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8c5cabe View commit details
    Browse the repository at this point in the history

  7. Adding test for hitting deadline when ingester.Push is used 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f927f76 View commit details
    Browse the repository at this point in the history

  8. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0c3fbd4 View commit details
    Browse the repository at this point in the history

  9. Fix additional review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    45a8fe5 View commit details
    Browse the repository at this point in the history

  10. Get rid of finishPushRequest 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    bd686a5 View commit details
    Browse the repository at this point in the history

  11. Add unit test for startPushRequest 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    48e8d62 View commit details
    Browse the repository at this point in the history

  12. Activate circuit breaker on a successful completion of ingester.starting 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d374c83 View commit details
    Browse the repository at this point in the history

  13. Rename the output error of ingester.PushWithCleanup() 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    335d21a View commit details
    Browse the repository at this point in the history

  14. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e3b0849 View commit details
    Browse the repository at this point in the history

  15. Get rid of test-delay key from in context 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1d3a8bb View commit details
    Browse the repository at this point in the history

  16. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e136df3 View commit details
    Browse the repository at this point in the history