Add insight=true to ingest-storage log messages when data can't be ingested due to client errors #8194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
gotjosh
approved these changes
May 28, 2024
pkg/storage/ingest/pusher_test.go
Outdated
Co-authored-by: gotjosh <josue.abreu@gmail.com>
pstibrany
added a commit
that referenced
this pull request
May 28, 2024
…gested due to client errors (#8194) * Add insight=true label to log messages about client errors. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Update pkg/storage/ingest/pusher.go Co-authored-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
1 task
1 task
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
…gested due to client errors (grafana#8194) * Add insight=true label to log messages about client errors. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Update pkg/storage/ingest/pusher.go Co-authored-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When ingest-storage is processing push requests from Kafka, client errors for push request cause that data cannot be ingested, and no retries are done. We want to report such errors to users, and we do that by using
insightlabel.This PR adds
insight=truelabel to log messages about "client errors" to ingest-storage code.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.