Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimir query engine: add memory consumption per query limit #8230

Merged
merged 26 commits into from
Jun 3, 2024
Merged

Mimir query engine: add memory consumption per query limit #8230

merged 26 commits into from
Jun 3, 2024

Commits on May 30, 2024

  1. Make formatting consistent

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3a79cfd View commit details
    Browse the repository at this point in the history

  2. Initial version of LimitingPool

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    40c427a View commit details
    Browse the repository at this point in the history

  3. Move to operator package

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7e0a53e View commit details
    Browse the repository at this point in the history

  4. Move FPoint and HPoint pools next to LimitingPool

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ebecf9e View commit details
    Browse the repository at this point in the history

  5. Add methods for slices of HPoint to LimitingPool

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0b03553 View commit details
    Browse the repository at this point in the history

  6. Use LimitingPool everywhere

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    27f24fc View commit details
    Browse the repository at this point in the history

  7. Move pool to its own package and introduce interface

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0493b93 View commit details
    Browse the repository at this point in the history

  8. Move pool interface to types package

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1f3490e View commit details
    Browse the repository at this point in the history

  9. Add documentation for err-mimir-max-in-memory-samples-per-query

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    033fe4a View commit details
    Browse the repository at this point in the history

  10. Add limit CLI flag and config option

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b0c807b View commit details
    Browse the repository at this point in the history

  11. Add (failing) tests

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f89d7c4 View commit details
    Browse the repository at this point in the history

  12. Fix linting warnings

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3241525 View commit details
    Browse the repository at this point in the history

  13. Add another test case

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d86a2ab View commit details
    Browse the repository at this point in the history

  14. Add more slice types to LimitedPool.

    @charleskorn
    charleskorn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    c9e6ba0 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Rework limit to use estimated memory consumption, rather than a numbe… 

    …r of samples
    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    290f3fe View commit details
    Browse the repository at this point in the history

  2. Ensure float and bool slices are cleared.

    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    29ccb77 View commit details
    Browse the repository at this point in the history

  3. Update tests to use bytes rather than samples limit

    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f620085 View commit details
    Browse the repository at this point in the history

  4. Add limit to list of experimental features

    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6f105c0 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4baab11 View commit details
    Browse the repository at this point in the history

  6. Fix linting warning

    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    da341b8 View commit details
    Browse the repository at this point in the history

  7. Fix description of error

    @charleskorn
    charleskorn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0b8b82d View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Remove unnecessary interface and early enforcement of limit

    @charleskorn
    charleskorn committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c69cc08 View commit details
    Browse the repository at this point in the history

  2. Fix flag name

    @charleskorn
    charleskorn committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    499991e View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary interface

    @charleskorn
    charleskorn committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    fa70180 View commit details
    Browse the repository at this point in the history

  4. Remove unused methods

    @charleskorn
    charleskorn committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    479bf0c View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Address PR feedback

    @charleskorn
    charleskorn committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    86649ca View commit details
    Browse the repository at this point in the history