Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert if compactor runs out of disk space #8278

Merged
merged 18 commits into from
Jul 22, 2024

Conversation

replay
Copy link
Contributor

@replay replay commented Jun 5, 2024

Alerting if there is any increase in the new metric cortex_compactor_disk_out_of_space_errors_total which has been added by #8237 .

A Compactor running out of disk space is a non-transient condition which will likely keep failing until an operator resolves it, so it makes sense to alert on a single increase already.

@replay replay marked this pull request as ready for review June 5, 2024 09:44
@replay replay requested review from jdbaldry and a team as code owners June 5, 2024 09:44
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the technical review, this may need some revision. Ping me after those conversations are resolved and I can do another docs pass.

docs/sources/mimir/manage/mimir-runbooks/_index.md Outdated Show resolved Hide resolved
@dimitarvdimitrov
Copy link
Contributor

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

@replay
Copy link
Contributor Author

replay commented Jul 22, 2024

going to rebase this

replay added 10 commits July 22, 2024 13:04
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay force-pushed the alert-if-compactor-runs-out-of-disk-space branch from da0eb65 to 8bb0ed1 Compare July 22, 2024 11:05
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
replay and others added 3 commits July 22, 2024 18:31
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
Copy link
Contributor Author

replay commented Jul 22, 2024

Judging by the technical review, this may need some revision. Ping me after those conversations are resolved and I can do another docs pass.

@jdbaldry I think this is ready for merging. Would you mind taking another look please?

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some readability nits

docs/sources/mimir/manage/mimir-runbooks/_index.md Outdated Show resolved Hide resolved
docs/sources/mimir/manage/mimir-runbooks/_index.md Outdated Show resolved Hide resolved
docs/sources/mimir/manage/mimir-runbooks/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
replay and others added 3 commits July 22, 2024 19:14
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay enabled auto-merge (squash) July 22, 2024 17:22
@replay replay merged commit af7fe67 into main Jul 22, 2024
31 checks passed
@replay replay deleted the alert-if-compactor-runs-out-of-disk-space branch July 22, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants