-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alert if compactor runs out of disk space #8278
Conversation
...metamonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by the technical review, this may need some revision. Ping me after those conversations are resolved and I can do another docs pass.
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
going to rebase this |
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
da0eb65
to
8bb0ed1
Compare
...metamonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
Show resolved
Hide resolved
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@jdbaldry I think this is ready for merging. Would you mind taking another look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some readability nits
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Alerting if there is any increase in the new metric
cortex_compactor_disk_out_of_space_errors_total
which has been added by #8237 .A Compactor running out of disk space is a non-transient condition which will likely keep failing until an operator resolves it, so it makes sense to alert on a single increase already.