Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insight=true to push handlers #8294

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Add insight=true to push handlers #8294

merged 6 commits into from
Jun 6, 2024

Conversation

pstibrany
Copy link
Member

What this PR does

This PR adds insight=true label to push handlers when we're logging push error with 4xx status code.

This applies to both Prometheus and OTLP handlers. This PR also fixes some issues with updated OTLP handler found in #8227

Checklist

  • Tests updated.
  • [na] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pstibrany
Add insight=true to push handlers.
7bd2d01 
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner June 6, 2024 11:11
@pstibrany
CHANGELOG.md entry.
8b65360 
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany mentioned this pull request Jun 6, 2024
Merged
4 tasks
pracucci
pracucci reviewed Jun 6, 2024
View reviewed changes
pkg/distributor/push.go Outdated Show resolved Hide resolved
pracucci
pracucci approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Peter. I'm good with this change. I would just consider a more descriptive error message.

CHANGELOG.md Outdated Show resolved Hide resolved
@pstibrany
Address review feedback.
e866cad 
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany
Improve log message.
a84a6a1 
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany
One more iteration of error message clarification.
97b212b 
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany
Add comment about messages.
ef03da9 
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany merged commit 9c3c70b into main Jun 6, 2024
29 checks passed
@pstibrany pstibrany deleted the add-insight-label-to-push-handlers branch June 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstibrany @pracucci