Ruler shutdown behaviour improvements #8346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/ruler
branch
from
aa9f31b
to
93783be
Compare
pracucci
reviewed
Jun 25, 2024
charleskorn
force-pushed
the
charleskorn/ruler
branch
from
63af277
to
7443c4d
Compare
…xt canceled"` when the ruler shuts down cleanly.
…` introduced in prometheus/prometheus@086be26 when draining is enabled
charleskorn
force-pushed
the
charleskorn/ruler
branch
from
a541732
to
7a5ccdf
Compare
pracucci
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR improves the behaviour of rulers while shutting down.
In particular:
Rulers will no longer log
msg="error starting notifier discovery manager" err="context canceled"when they shut down cleanlyRulers will stop their notifiers after stopping rule evaluation, to allow for the notifier to send notifications from rules that are still evaluating when a ruler is asked to stop
If
-ruler.drain-notification-queue-on-shutdown=true, then rulers will now also drain their notification queues when shutting down, rather than dropping any inflight notifications. Once we've tested this further at Grafana Labs, I'll make this the default, but for now, I've left this disabled by default.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.