-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query-tee improvements #8419
Query-tee improvements #8419
Conversation
…add them to trace spans too
e97cc56
to
1d7abaa
Compare
1d7abaa
to
5e72af5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff, thanks! Lgtm, just nits.
"timeout": []string{"60s"}, | ||
"time": []string{"2024-06-10T20:30:40Z"}, | ||
}, | ||
expectedForm: url.Values{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) could also test where both the form and url params are set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean time
is present in both? Or some parameters are in the URL and some are in the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant some parameters are the URL and some in the body. I guess it could also be worth ensuring that if it is set in both that they are passed through unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 527c416.
If time
is set in both, then I think all bets are off, so I've left that out for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's set in both I would expect the set values to be passed on. What happens from there I'm unsure, but the former is still something we could check here. Not necessary though imo.
Co-authored-by: Joshua Hesketh <joshua.hesketh@grafana.com>
…body and some are in URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
What this PR does
This PR makes a number of improvements to query-tee. The most notable changes are:
path
,query
androute_name
are now set on all log messages emitted while processing a request.time
parameter now have this explicitly set for outgoing requests to backends, to prevent comparison failures due to different backends using a slightly different timestamp. This is optional, but enabled by default.I've tried to make each commit self-contained, and I recommend reviewing each commit separately.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.