Enable -blocks-storage.bucket-store.max-concurrent-queue-timeout by default #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
deleted the
set-blocks-storage.bucket-store.max-concurrent-queue-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I propose to enable
-blocks-storage.bucket-store.max-concurrent-queue-timeoutby default, with a value of 5s. That's how we run it at Grafana Cloud and looks working fine. The rationale is that if the store-gateway concurrency is hit, it probably means the store-gateway is overloaded and we prefer to fast fail so that the querier will retry on another store-gateway (3 store-gateways will be tried, assuming RF=3).Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.