-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ingest storage config doc and changelog #8503
Expose ingest storage config doc and changelog #8503
Conversation
d7fd803
to
1efcf6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine adding it to unreleased section, since all the options are still hidden in 2.13.
I'd suggest documenting the following mixin config options:
ingest_storage_enabled
-- enables alerts for ingest-storageshow_ingest_storage_panels
-- shows ingest-storage panels
Thanks @tacole02. I should have addressed all your comments. |
5b64e4a
to
0e06226
Compare
I meant documenting them in the changelog. However
entry. |
I retro-actively added the PR number to that entry. |
…ANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
536a145
to
4b38352
Compare
What this PR does
The Kafka-based ingest storage is still experimental, but we're moving closer to start running it in few production clusters at Grafana Labs. I think it's the right time to include it in the auto-generated config and, from now on, to mention changes to the CHANGELOG.
I've added the CHANGELOG entry under
main / unreleased
branch, even if it's not technically correct, because all changes are included inv2.13.0-rc.0
. I'm open to feedback on how to handle it. The reason why I've written it undermain / unreleased
is because we haven't publicly mentioned it yet, but will be mentioned as experimental feature in the next release (so 2.14).Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.