Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdnotify send startup and stop events #8541

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

pbailhache
Copy link
Contributor

@pbailhache pbailhache commented Jun 27, 2024

What this PR does

Add two call to send event about service startup and stop.
Hooked on the service manager healthy and stopped handlers.

Which issue(s) this PR fixes or relates to

Fixes #8220

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pbailhache pbailhache requested review from stevesg, grafanabot and a team as code owners June 27, 2024 08:24
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ying-jeanne ying-jeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notification skipped when NOTIFY_SOCKET not set, for no systemd Init system err ignored. Corss-platform compilation should work. LGTM

@ying-jeanne ying-jeanne merged commit e80bb94 into grafana:main Jun 27, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add facultative forking mode or systemd-notify at mimir start
3 participants