store-gateway: dont leak goroutines when preloading #8546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered this while working on XXX. This shouldn't be a bug today because nothing above the preloading iterator looks at the context. But it can become a problem in the future. I also verified in a few production clusters at GL and couldn't spot a gradual increase in the number of goroutines. It's blocking detecting leaking goroutines in my work for XXX, so I'd like to fix it first. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
|
I merged this to unblock other PRs, but happy to address concerns or feedback later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I discovered this while working on #8389. This shouldn't be a bug today because nothing above the preloading iterator looks at the context (IIRC this was the reason I didn't check the context in the first place). But it can become a problem in the future. I also verified in a few production clusters at GL and couldn't spot a gradual increase in the number of goroutines.
It's blocking detecting leaking goroutines in my work for #8389, so I'd like to fix it first.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.