Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL reader changes #8568

Merged
merged 3 commits into from
Jul 1, 2024
Merged

WAL reader changes #8568

merged 3 commits into from
Jul 1, 2024

Conversation

pstibrany
Copy link
Member

What this PR does

This PR modifies wal-reader tool:

  • Renamed -series-entries to -print-series
  • Renamed -print-series-with-samples to -print-samples (it enables printing of individual samples, tombstones, exemplars or histograms)
  • References to unknown series from Samples, Exemplars, histogram or tombstones records are now always logged.

Checklist

  • [na] Tests updated.
  • [na] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Renamed `-print-series-with-samples` to `-print-samples`

References to unknown series from Samples, Exemplars, histogram or tombstones records are now always logged.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner July 1, 2024 12:36
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nit.

tools/wal-reader/main.go Outdated Show resolved Hide resolved
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
@pstibrany pstibrany merged commit 9b8b5b7 into main Jul 1, 2024
29 checks passed
@pstibrany pstibrany deleted the wal-reader-updates branch July 1, 2024 14:54
Ivaka pushed a commit to Ivaka/mimir that referenced this pull request Jul 3, 2024
* Renamed `-series-entries` to `-print-series`
Renamed `-print-series-with-samples` to `-print-samples`

References to unknown series from Samples, Exemplars, histogram or tombstones records are now always logged.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>

* CHANGELOG.md

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>

* Update tools/wal-reader/main.go

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

---------

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants