Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove experimental logging overutilized query components #8689

Merged
merged 1 commit into from
Jul 11, 2024
Merged

remove experimental logging overutilized query components #8689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions pkg/scheduler/queue/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,28 +364,6 @@ func (q *RequestQueue) trySendNextRequestForQuerier(waitingConn *waitingQuerierC
return false
}

{
// temporary observation of query component load balancing behavior before full implementation
schedulerRequest, ok := req.req.(*SchedulerRequest)
if ok {
queryComponentName := schedulerRequest.ExpectedQueryComponentName()
exceedsThreshold, queryComponent := q.QueryComponentUtilization.ExceedsThresholdForComponentName(
queryComponentName,
int(q.connectedQuerierWorkers.Load()),
q.queueBroker.tree.ItemCount(),
q.waitingQuerierConnsToDispatch.Len(),
)

if exceedsThreshold {
level.Info(q.log).Log(
"msg", "experimental: querier worker connections in use by query component exceed utilization threshold. no action taken",
"query_component_name", queryComponentName,
"overloaded_query_component", queryComponent,
)
}
}
}

reqForQuerier := requestForQuerier{
req: req.req,
lastTenantIndex: waitingConn.lastTenantIndex,
Expand Down
Loading