query-tee: add support for comparing native histograms in results #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/query-tee-native-histograms
branch
from
0147308
to
718ca00
Compare
krajorama
approved these changes
Jul 15, 2024
| return math.Abs(first-second) <= opts.Tolerance | ||
| } | ||
|
|
||
| func compareSampleHistogramPair(expected, actual model.SampleHistogramPair, opts SampleComparisonOptions) error { |
There was a problem hiding this comment.
nit: call inputs first and second as compareSampleValue. Function doesn't care and in line with the other function.
There was a problem hiding this comment.
This function does care about which input is which, as they're used to produce the error message when comparison fails (eg. "expected timestamp X but got Y").
The names here mirror those of compareSamplePair, which uses these names for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds support for comparing native histograms in query results to query-tee.
Previously, any native histograms in query results were ignored.
I've also taken this opportunity to clarify some of the error messages generated when results do not match, and to replace the use of
errors.Wrapwithfmt.Errorfinresponse_comparator.go.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.