Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated query-frontend align_queries_with_step YAML setting #8733

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

56quarters
Copy link
Contributor

What this PR does

The setting has been moved to default and per-tenant limits since Mimir 2.12. The command line flag for the setting is not changing.

Which issue(s) this PR fixes or relates to

Related #6712

Related #6714

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

The setting has been moved to default and per-tenant `limits` since Mimir 2.12.
The command line flag for the setting is not changing.

Related #6712

Related #6714

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review July 15, 2024 15:40
@56quarters 56quarters requested a review from a team as a code owner July 15, 2024 15:40
@56quarters 56quarters merged commit 94bf5bd into main Jul 15, 2024
29 checks passed
@56quarters 56quarters deleted the 56quarters/step-align branch July 15, 2024 16:39
56quarters added a commit that referenced this pull request Jul 15, 2024
Update a few more places that were using `align_queries_with_step`:

* Update mimirtool Cortex migration tool to use new `limits.align_queries_with_step` setting
* Remove use of `align_queries_with_step` from Docker compose config

Follow up to #8733

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this pull request Jul 15, 2024
Follow up to #8733

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this pull request Jul 15, 2024
Follow up to #8733

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants