Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboards: add compactor autoscaling panels #8777

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Dashboards: add compactor autoscaling panels #8777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
* [ENHANCEMENT] Dashboards: Add panels for monitoring ingester autoscaling when not using ingest-storage. These panels are disabled by default, but can be enabled using the `autoscaling.ingester.enabled: true` config option. #8484
* [ENHANCEMENT] Dashboards: add panels to show writes to experimental ingest storage backend in the "Mimir / Ruler" dashboard, when `_config.show_ingest_storage_panels` is enabled. #8732
* [ENHANCEMENT] Dashboards: show all series in tooltips on time series dashboard panels. #8748
* [ENHANCEMENT] Dashboards: add compactor autoscaling panels to "Mimir / Compactor" dashboard. The panels are disabled by default, but can be enabled setting `_config.autoscaling.compactor.enabled` to `true`. #8777
* [BUGFIX] Dashboards: fix "current replicas" in autoscaling panels when HPA is not active. #8566
* [BUGFIX] Alerts: do not fire `MimirRingMembersMismatch` during the migration to experimental ingest storage. #8727

Expand Down
4 changes: 4 additions & 0 deletions operations/mimir-mixin/config.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,10 @@
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'ingester-zone-a',
},
compactor: {
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'compactor',
},
},


Expand Down
4 changes: 4 additions & 0 deletions operations/mimir-mixin/dashboards/compactor.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,5 +360,9 @@ local fixTargetsForTransformations(panel, refIds) = panel {
.addRows($.getObjectStoreRows('Object Store', 'compactor'))
.addRow(
$.kvStoreRow('Key-value store for compactors ring', 'compactor', '.+')
)
.addRowIf(
$._config.autoscaling.compactor.enabled,
$.cpuBasedAutoScalingRow('Compactor'),
),
}
13 changes: 13 additions & 0 deletions operations/mimir-mixin/dashboards/dashboard-utils.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,19 @@ local utils = import 'mixin-utils/utils.libsonnet';
|||
),

cpuBasedAutoScalingRow(componentTitle)::
local componentName = std.strReplace(std.asciiLower(componentTitle), '-', '_');
super.row('%s – autoscaling' % [componentTitle])
.addPanel(
$.autoScalingActualReplicas(componentName)
)
.addPanel(
$.autoScalingDesiredReplicasByAverageValueScalingMetricPanel(componentName, 'CPU', 'cpu')
)
.addPanel(
$.autoScalingFailuresPanel(componentName)
),

cpuAndMemoryBasedAutoScalingRow(componentTitle)::
local componentName = std.strReplace(std.asciiLower(componentTitle), '-', '_');
super.row('%s – autoscaling' % [componentTitle])
Expand Down
Loading