Add PartitionReader.WaitReadConsistencyUntilOffset() #8809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
dimitarvdimitrov
approved these changes
Jul 24, 2024
| @@ -172,165 +172,217 @@ func TestPartitionReader_WaitReadConsistency(t *testing.T) { | |||
| t.Run("should return after all produced records have been consumed", func(t *testing.T) { | |||
| t.Parallel() | |||
|
|
|||
| consumedRecords := atomic.NewInt64(0) | |||
| for _, withOffset := range []bool{false, true} { | |||
| t.Run(fmt.Sprintf("with offset %v", withOffset), func(t *testing.T) { | |||
There was a problem hiding this comment.
these tests should be Parallel() too, right?
There was a problem hiding this comment.
same applies to the other tests in the file
There was a problem hiding this comment.
Yep good point, will do, thanks
…roducedOffset_And_WaitReadConsistencyUntilOffset() Signed-off-by: Marco Pracucci <marco@pracucci.com>
dimitarvdimitrov
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is another preliminary to ease the review of #8808. In this PR I'm adding
PartitionReader.WaitReadConsistencyUntilOffset()which is likeWaitReadConsistencyUntilLastProducedOffset()but allows to specify the offset to wait for.Note to reviewers:
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.