Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add store-gateway autoscaling row to reads dashboard #8824

Merged
merged 5 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
* [ENHANCEMENT] Alerts: `MimirRunningIngesterReceiveDelayTooHigh` alert has been tuned to be more reactive to high receive delay. #8538
* [ENHANCEMENT] Dashboards: improve end-to-end latency and strong read consistency panels when experimental ingest storage is enabled. #8543
* [ENHANCEMENT] Dashboards: Add panels for monitoring ingester autoscaling when not using ingest-storage. These panels are disabled by default, but can be enabled using the `autoscaling.ingester.enabled: true` config option. #8484
* [ENHANCEMENT] Dashboards: Add panels for monitoring store-gateway autoscaling. These panels are disabled by default, but can be enabled using the `autoscaling.store_gateway.enabled: true` config option. #8824
* [ENHANCEMENT] Dashboards: add panels to show writes to experimental ingest storage backend in the "Mimir / Ruler" dashboard, when `_config.show_ingest_storage_panels` is enabled. #8732
* [ENHANCEMENT] Dashboards: show all series in tooltips on time series dashboard panels. #8748
* [ENHANCEMENT] Dashboards: add compactor autoscaling panels to "Mimir / Compactor" dashboard. The panels are disabled by default, but can be enabled setting `_config.autoscaling.compactor.enabled` to `true`. #8777
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20286,7 +20286,7 @@ data:
},
{
"datasource": "$datasource",
"description": "### Autoscaler failures rate\nThe rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom\nmetrics server is unable to query the scaling metric from Prometheus so the autoscaler woudln't work properly.\n\n",
"description": "### Autoscaler failures rate\nThe rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom\nmetrics server is unable to query the scaling metric from Prometheus so the autoscaler wouldn't work properly.\n\n",
"fieldConfig": {
"defaults": {
"custom": {
Expand Down Expand Up @@ -26080,7 +26080,7 @@ data:
},
{
"datasource": "$datasource",
"description": "### Autoscaler failures rate\nThe rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom\nmetrics server is unable to query the scaling metric from Prometheus so the autoscaler woudln't work properly.\n\n",
"description": "### Autoscaler failures rate\nThe rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom\nmetrics server is unable to query the scaling metric from Prometheus so the autoscaler wouldn't work properly.\n\n",
"fieldConfig": {
"defaults": {
"custom": {
Expand Down Expand Up @@ -40380,7 +40380,7 @@ data:
},
{
"datasource": "$datasource",
"description": "### Autoscaler failures rate\nThe rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom\nmetrics server is unable to query the scaling metric from Prometheus so the autoscaler woudln't work properly.\n\n",
"description": "### Autoscaler failures rate\nThe rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom\nmetrics server is unable to query the scaling metric from Prometheus so the autoscaler wouldn't work properly.\n\n",
"fieldConfig": {
"defaults": {
"custom": {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions operations/mimir-mixin/config.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,10 @@
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'ruler-querier',
},
store_gateway: {
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'store-gateway-zone-a',
},
distributor: {
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'distributor',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
title,
|||
The rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom
metrics server is unable to query the scaling metric from Prometheus so the autoscaler woudln't work properly.
metrics server is unable to query the scaling metric from Prometheus so the autoscaler wouldn't work properly.
|||
),

Expand Down
34 changes: 33 additions & 1 deletion operations/mimir-mixin/dashboards/reads.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -296,11 +296,43 @@ local filename = 'mimir-reads.json';
title,
|||
The rate of failures in the KEDA custom metrics API server. Whenever an error occurs, the KEDA custom
metrics server is unable to query the scaling metric from Prometheus so the autoscaler woudln't work properly.
metrics server is unable to query the scaling metric from Prometheus so the autoscaler wouldn't work properly.
|||
),
)
)
.addRowIf(
$._config.autoscaling.store_gateway.enabled,
$.row('Store-gateway – autoscaling')
.addPanel(
$.autoScalingActualReplicas('store_gateway') + { title: 'Replicas (leader zone)' } +
$.panelDescription(
'Replicas (leader zone)',
|||
The minimum, maximum, and current number of replicas for the leader zone of store-gateways.
Other zones scale to follow this zone (with delay for downscale).
|||
)
)
.addPanel(
$.timeseriesPanel('Replicas') +
$.panelDescription('Replicas', 'Number of store-gateway replicas per zone.') +
$.queryPanel(
[
'sum by (%s) (up{%s})' % [$._config.per_job_label, $.jobMatcher($._config.job_names.store_gateway)],
],
[
'{{ %(per_job_label)s }}' % $._config.per_job_label,
],
),
)
.addPanel(
$.autoScalingDesiredReplicasByValueScalingMetricPanel('store_gateway', '', '') + { title: 'Desired replicas (leader zone)' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly something for a future PR: would it be possible to show the desired replicas for all three zones in this panel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 That would definitely be useful to see. Let me see what I can do.

)
.addPanel(
$.autoScalingFailuresPanel('store_gateway') + { title: 'Autoscaler failures rate' }
),
)
.addRow(
$.kvStoreRow('Store-gateway – key-value store for store-gateways ring', 'store_gateway', 'store-gateway')
)
Expand Down
Loading