Fix cortex_ingest_storage_strong_consistency_wait_duration_seconds tracking in query-frontend #8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking in query-frontend Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
added a commit
that referenced
this pull request
Jul 30, 2024
…acking in query-frontend (#8845) * Fix cortex_ingest_storage_strong_consistency_wait_duration_seconds tracking in query-frontend Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com>
4 tasks
pracucci
added a commit
that referenced
this pull request
Jul 30, 2024
…duration_seconds tracking in query-frontend (#8845) (#8849) * Fix cortex_ingest_storage_strong_consistency_wait_duration_seconds tracking in query-frontend (#8845) * Fix cortex_ingest_storage_strong_consistency_wait_duration_seconds tracking in query-frontend Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix TestPrometheusCodec_EncodeMetricsQueryRequest_ShouldPropagateHeadersInAllowList flakyness (#8841) * Fix TestPrometheusCodec_EncodeMetricsQueryRequest_ShouldPropagateHeadersInAllowList flakyness Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added PR number to CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Amend CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In #8808 I did a mistake related to
cortex_ingest_storage_strong_consistency_wait_duration_seconds(latency) tracking in the query-frontend: the metric currently tracks the entire execution of downstream roundtrippers too, instead of just the time spent waiting for the last produced offsets.This PR fixes it.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.