End to end test rule concurrency #8846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Jul 30, 2024
gotjosh
added a commit
that referenced
this pull request
Jul 30, 2024
…-percentage` To ensure that its value is 0 or greater. NB: I double checked that the code doesn't panic with 0 and I'll add a test in #8846. Do let me know if you think a unit test is also a good idea because in my head it seemd superflous. Signed-off-by: gotjosh <josue.abreu@gmail.com>
4 tasks
gotjosh
added a commit
that referenced
this pull request
Jul 30, 2024
…-percentage` (#8858) * Validate `-ruler.independent-rule-evaluation-concurrency-min-duration-percentage` To ensure that its value is 0 or greater. NB: I double checked that the code doesn't panic with 0 and I'll add a test in #8846. Do let me know if you think a unit test is also a good idea because in my head it seemd superflous. Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
… expectations Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
e2e-test-rule-concurrency
branch
from
1efeb01
to
3c9e144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds an end to ends test to ensure rule concurrency is working correctly. A follow up to #8146
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.