Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: Improve min-time-between-zones-downscale setting during ingest storage migration #8873

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Aug 1, 2024

What this PR does

We recently migrated a Mimir cluster to the new experimental ingest storage architecture and we noticed a couple of things to improve in the jsonnet-coded migration process:

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…from '0s' to '0' to keep it consistent with the setting used when ingest storage ingesters autoscaling is enabled

Signed-off-by: Marco Pracucci <marco@pracucci.com>
…n_delay:false until ingesters autoscaling is enabled

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner August 1, 2024 08:35
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pracucci pracucci merged commit 4c70a63 into main Aug 1, 2024
29 checks passed
@pracucci pracucci deleted the improve-min-time-between-zones-downscale-during-ingest-storage-migration branch August 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants