Dashboards: add 'Read path' selector to 'Mimir / Queries' dashboard #8878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we agree on the approach, then I will spend a week or so fixing the linter 😠 |
Perhaps "user" rather than "standard"? It's still not perfect, but might be a bit clearer |
pracucci
force-pushed
the
add-read-path-filter-in-queries-dashboard
branch
from
64bf569
to
a50052e
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-read-path-filter-in-queries-dashboard
branch
from
0ae18a0
to
6fb2db8
Compare
Discussed offline. Charles offered few better options, I picked "main". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The Queries dashboard doesn't offer a consistent view over queries. As supported by the OSS jsonnet, at Grafana Labs we currently have 2 read path stacks:
The panels in the Queries dashboard show a mix of the two. For components shared between the 2 read stacks (ingesters and store-gateways) we show metrics related to all queries. For components specific to a stack, we don't query
ruler-*components, so we miss rule evaluations from Queries dashboard. This is confusing to me.The easy solution would be to always add
ruler-*components to the query, but after a quick internal feedback loop looks like there's people liking the ability to see metrics for a specific read path (I see value as well).In this PR I'm proposing to add a "Read path" selector to the Queries dashboard. It has 3 options:
Note: I'm looking for better option names, any suggestion?
Here you can see a video of the selector in action:
demo.mov
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.