Mimir query engine: add native histogram custom bucket-related annotations #8924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
reviewed
Aug 7, 2024
…ts are seen at the same timestamp, or if incompatible custom buckets are seen at the same timestamp
# Conflicts: # CHANGELOG.md
…an ignored sample
charleskorn
force-pushed
the
charleskorn/nhcb-annotations
branch
from
446c623
to
4ff023d
Compare
charleskorn
force-pushed
the
charleskorn/nhcb-annotations
branch
from
90a09d1
to
14cbaf7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds support for the following warnings in
rateandsumin MQE:This uncovered two issues in Prometheus' engine:
rateover native histograms with mix of custom and exponential buckets prometheus/prometheus#14609sumandavgover mixed custom and exponential buckets, or incompatible custom buckets prometheus/prometheus#14611I've opted to skip the affected tests that confirm our test cases match Prometheus' engine to unblock this PR.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.