Make additional-query-queue-dimensions-enabled into no-op flags
#8984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
force-pushed
the
casie/no-op-additional-queue-dimensions-flag
branch
2 times, most recently
from
b854f3f
to
53470be
Compare
chencs
commented
Aug 13, 2024
chencs
force-pushed
the
casie/no-op-additional-queue-dimensions-flag
branch
from
53470be
to
67e4d02
Compare
francoposa
approved these changes
Aug 13, 2024
tacole02
approved these changes
Aug 13, 2024
chencs
force-pushed
the
casie/no-op-additional-queue-dimensions-flag
branch
from
34eb0e7
to
4c4d8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes
query-frontend.additional-query-queue-dimensions-enabledandquery-scheduler.additional-query-queue-dimensions-enabledinto no-op flags, in preparation for fully removing them. In future changes, Mimir will always include "query components" as a queue dimension, so the option is no longer needed.Users can (and should) delete any
additional-query-queue-dimensions-enabledflags from their configurations to avoid running into issues when the flags are removed.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.