-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerts: migrate RequestErrors and RulerRemoteEvaluationFailing to native histograms #9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native histogram version Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/native-histogram-alerts
branch
from
August 14, 2024 16:27
252a7fe
to
35d138f
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
krajorama
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with nits
else { | ||
alert: $.alertName('RequestErrors'), | ||
expr: if histogram == 'classic' then query.classic else query.native, | ||
'for': '15m', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
'for': '15m', | |
for: '15m', |
else { | ||
alert: $.alertName('RulerRemoteEvaluationFailing'), | ||
expr: if histogram == 'classic' then query.classic else query.native, | ||
'for': '5m', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
'for': '5m', | |
for: '5m', |
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR extends alerts
RequestErrors
andRulerRemoteEvaluationFailing
with their native histogram counterpart.Which issue(s) this PR fixes or relates to
Related to #7154
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.