querier: set minimum concurrency to 4 for query-scheduler's new querier-worker queue prioritization #9054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
reviewed
Aug 20, 2024
|
oh no that damn suggestion thing created a merge commit |
francoposa
force-pushed
the
francoposa/querier-set-minimum-concurrency-for-query-scheduler-queue-prioritization
branch
from
7667a58
to
b1773af
Compare
…er-worker queue prioritization
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
francoposa
force-pushed
the
francoposa/querier-set-minimum-concurrency-for-query-scheduler-queue-prioritization
branch
from
b1773af
to
4aac9c1
Compare
chencs
reviewed
Aug 20, 2024
chencs
reviewed
Aug 20, 2024
Yeah, I never actually use the suggestion thing (or do any code changes like resolve merge conflicts in-browser) for this reason, I just copy the suggested changes into my branch. I'm not sure if there's a better way, but I haven't found it. |
chencs
approved these changes
Aug 21, 2024
francoposa
deleted the
francoposa/querier-set-minimum-concurrency-for-query-scheduler-queue-prioritization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring for constant should be a sufficient description, but will expand a bit here:
When we move to a new RequestQueue dequeuing algorithm, we will modulo querier-worker IDs to distribute them across 4 request queue dimensions, one each for the "expected query component" which is assigned to the query request: ingester, store-gateway, both, or unknown.
Having querier-worker connections < num queue dimensions will result in queue starvation unless not all 4 queue dimensions are active. In any minimally utilized cluster, we expect all 4 dimensions will exist at almost all times.
Because the queriers have no centralized knowledge or coordination of how many queriers exist in the cluster, we must set a minimum of 4 for each querier<->request queue instance connection, where a "request queue instance" is a query-frontend or a query-scheduler.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.