Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: improve ingest storage queries #9170

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Sep 2, 2024

What this PR does

This is the follow-up to #8175

Here I'm updating the dashboards' queries for the "classic storage" instances, to exclude the ingesters running under the "ingest storage" mode. This is to prevent overcounting during the migration from classic to ingest storage.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo requested a review from a team as a code owner September 2, 2024 09:39
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo force-pushed the vldmr/dash-tenants-ingest-storage branch from 4790255 to a626e1f Compare September 2, 2024 09:43
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this to the list of PRs related to ingest storage in the changelog? IIRC there should be one entry with a long list of PRs

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo merged commit e22f909 into main Sep 2, 2024
31 checks passed
@narqo narqo deleted the vldmr/dash-tenants-ingest-storage branch September 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants