Attach consistency check debug logs to trace spans #9213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9213-to-r306 origin/r306
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 2bc501a3182e4d33c58a63447fb24ea98f7368ef
# Push it to GitHub
git push --set-upstream origin backport-9213-to-r306
git switch main
# Remove the local backport branch
git branch -D backport-9213-to-r306Then, create a pull request where the |
charleskorn
added a commit
that referenced
this pull request
Sep 6, 2024
* Attach consistency check debug logs to trace spans * Add changelog entry (cherry picked from commit 2bc501a) # Conflicts: # CHANGELOG.md
charleskorn
added a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR improves the logging done during consistency checks for queries to store-gateways.
Specifically, it attaches the log messages emitted by
BlocksConsistency.NewTrackerto the active trace span as events, so these can be viewed alongside the other related events emitted byblocksStoreQuerier.queryWithConsistencyCheck.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.