[r307] Mimir query engine: fix issue where sum and avg results over native histograms can be corrupted
#9264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve histograms can be corrupted (#9260) * Fix issue where `sum` and `avg` results over native histograms can be corrupted * Add changelog entry * Add test and fix further issue * Address PR feedback: add comments * Address PR feedback: clarify comments * Address PR feedback: move `RemoveReferencesToRetainedHistogram` to `InstantVectorSeriesData` type * Remove references to uncopied histograms in later points * Fix typo in comment (cherry picked from commit 5a18dba)
charleskorn
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5a18dba from #9260