Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE: Native histogram lookback should re-use existing histograms #9272

Merged
merged 3 commits into from
Sep 12, 2024
Merged

MQE: Native histogram lookback should re-use existing histograms #9272

merged 3 commits into from
Sep 12, 2024

Conversation

jhesketh
Copy link
Contributor

As per the code comments, the consumer is expected to check for repeated histograms.

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh
MQE: Native histogram lookback should re-use existing histograms
0c576c2 
As per the code comments, the consumer is expected to check for repeated
histograms.
@jhesketh jhesketh requested a review from a team as a code owner September 11, 2024 13:47
charleskorn
charleskorn approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 🚀

LGTM modulo suggestion for extra check in test

pkg/streamingpromql/operators/instant_vector_selector_test.go Show resolved Hide resolved
@jhesketh jhesketh enabled auto-merge (squash) September 12, 2024 01:18
@jhesketh jhesketh merged commit db75986 into grafana:main Sep 12, 2024
31 checks passed
grafanabot pushed a commit that referenced this pull request Sep 12, 2024
@jhesketh @grafanabot
MQE: Native histogram lookback should re-use existing histograms (#9272)
5622daf 
* MQE: Native histogram lookback should re-use existing histograms

As per the code comments, the consumer is expected to check for repeated
histograms.

* Update CHANGELOG

* Add extra check

(cherry picked from commit db75986)
@grafanabot grafanabot mentioned this pull request Sep 12, 2024
Closed
@jhesketh jhesketh deleted the jhesketh/mqe-nh-lookbacks branch September 12, 2024 01:41
grafanabot pushed a commit that referenced this pull request Sep 12, 2024
@jhesketh @grafanabot
MQE: Native histogram lookback should re-use existing histograms (#9272)
1458eac 
* MQE: Native histogram lookback should re-use existing histograms

As per the code comments, the consumer is expected to check for repeated
histograms.

* Update CHANGELOG

* Add extra check

(cherry picked from commit db75986)
@grafanabot grafanabot mentioned this pull request Sep 12, 2024
Merged
jhesketh added a commit that referenced this pull request Sep 12, 2024
@grafanabot @jhesketh
MQE: Native histogram lookback should re-use existing histograms (#9272…
a5285dd 
…) (#9276)

* MQE: Native histogram lookback should re-use existing histograms

As per the code comments, the consumer is expected to check for repeated
histograms.

* Update CHANGELOG

* Add extra check

(cherry picked from commit db75986)

Co-authored-by: Joshua Hesketh <joshua.hesketh@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
backport r307
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhesketh @charleskorn