Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka replay speed: adjust batchingQueueCapacity #9344

Merged
merged 7 commits into from
Sep 20, 2024
Merged

kafka replay speed: adjust batchingQueueCapacity #9344

merged 7 commits into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. kafka replay speed: adjust batchingQueueCapacity 

    I made 2000 up when we were flushing individual series to the channel.
Then 2000 might have made sense, but when flushing whole WriteRequests
a capacity of 1 should be sufficient.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    858f453 View commit details
    Browse the repository at this point in the history

  2. Increase errCh capacity 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a1b465e View commit details
    Browse the repository at this point in the history

  3. Explain why +1 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5445302 View commit details
    Browse the repository at this point in the history

  4. Set capacity to 5 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e2f2618 View commit details
    Browse the repository at this point in the history

  5. Update pkg/storage/ingest/pusher.go 

    Co-authored-by: gotjosh <josue.abreu@gmail.com>
    @dimitarvdimitrov @gotjosh
    dimitarvdimitrov and gotjosh authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5f124af View commit details
    Browse the repository at this point in the history

  6. Improve test 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5c882fa View commit details
    Browse the repository at this point in the history

  7. Update pkg/storage/ingest/pusher.go

    @dimitarvdimitrov
    dimitarvdimitrov authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cf30cbf View commit details
    Browse the repository at this point in the history