Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestIngester_PushToStorage_CircuitBreaker: increase initial delay #9351

Merged
merged 2 commits into from
Sep 20, 2024
Merged

TestIngester_PushToStorage_CircuitBreaker: increase initial delay #9351

merged 2 commits into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. TestIngester_PushToStorage_CircuitBreaker: increase initial delay 

    Fixes XXX
I believe there's a race between sending the first request and then collecting the metrics. It's possible that we collect the metrics longer than 200ms after the first request, at which point the CB has opened. I could reproduce XXX by reducing the initialDelay to 10ms.

This PR increases it to 1 hour so that we're more sure that the delay hasn't expired when we're collecting the metrics.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6e8ff84 View commit details
    Browse the repository at this point in the history

  2. Adjust all tests 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a299bcd View commit details
    Browse the repository at this point in the history