kafka replay speed: upstream local development environment #9455
+331
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes several changes to development/mimir-ingest-storage * deploys a jaeger instance to collect traces * deploys ingester-zone-c-61. This ingester is totally separate from the other two zones. The idea is to be able to feed its partition with old data and test replay speed. That ingester doesn't ingest metrics from the cluster itself, so being down doesn't affect the cluster's query availability * deploys 3 kafkas with RF=2 so that we can bring down brokers and test how our code reacts to leader reelections * optinally enabled dlv debugging for the Mimir images * configures ingesters to use concurrent fetching Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
narqo
reviewed
Oct 8, 2024
Comment on lines
38
to
45
| }], | ||
| [{ | ||
| __address__ = "mimir-write-zone-c-61:8080", | ||
| cluster = "docker-compose", | ||
| container = "mimir-write", | ||
| namespace = "mimir-read-write-mode", | ||
| job = "mimir-write-zone-c", | ||
| }], |
There was a problem hiding this comment.
(nit) Seems that tabs and spaces are mixed in this config here, right? ;)
There was a problem hiding this comment.
i think it's only using spaces.. i asked goland to convert "to spaces" and it said it's already formatted. i fixed the indentation of this line in the meantime
There was a problem hiding this comment.
@dimitarvdimitrov have you forgotten to push the changes, maybe? The indentation is still off here ;)
There was a problem hiding this comment.
this is what i pushed f5b6bcb
i think GH doesn't update the diff on the comment
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
narqo
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is the fourth of series of PRs to upstream the code for improving Kafka replay speed in the ingester.
This PR makes several changes to development/mimir-ingest-storage
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.