Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc about max number of failing zone #9512

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

ilmiye
Copy link
Contributor

@ilmiye ilmiye commented Oct 3, 2024

The doc related to maximum number of failing zone to operate is wrong.

You say that the system can tolerate failures as long as the number of failing zones is fewer than floor(replication_factor / 2). For example:

Replication Factor = 3 => floor(3 / 2) = 1 > max-num-of-failing-zone => max-num-of-failing-zone = 0

However, we know that Mimir can tolerate 1 zone loss when RF=3.

I updated the doc to give number of healthy zone instead of number of maximum failing zone to operate.

@ilmiye ilmiye requested review from tacole02 and a team as code owners October 3, 2024 15:00
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is much clearer!

Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
@ilmiye
Copy link
Contributor Author

ilmiye commented Oct 3, 2024

Also, the doc says Deploying Grafana Mimir clusters to more zones than the configured replication factor does not have a negative impact. but it does not mention what would be the benefits of deploying more Mimir zone than RF.

In addition, to have a section which mentions read path implications of number-of-mimir-zone > RF situation would be very beneficial. Like how Querier selects the ingesters with related data since not all data exists in all zones now.

@56quarters
Copy link
Contributor

Also, the doc says Deploying Grafana Mimir clusters to more zones than the configured replication factor does not have a negative impact. but it does not mention what would be the benefits of deploying more Mimir zone than RF.

In addition, to have a section which mentions read path implications of number-of-mimir-zone > RF situation would be very beneficial. Like how Querier selects the ingesters with related data since not all data exists in all zones now.

Opened #9513 to keep track of those improvements after merging this PR.

@56quarters 56quarters merged commit 42dd5e2 into grafana:main Oct 3, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants