feat(cli): extVars #178
Merged
feat(cli): extVars #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two flags for working with extVars: - `-e` / `--extCode`: Allows to bind any Jsonnet value (anything) to the extVar. This flag is superior to `--extVar`, because it also handles ints, bools, objects and arrays. **Strings need to be quoted**. - `--extVar`: Only strings, but takes them unqouted. Added for compatibility reasons to `jsonnet`.
sh0rez
added
kind/feature
rfratto
approved these changes
Jan 21, 2020
| // Eval returns the raw evaluated Jsonnet and the parsed env used for evaluation | ||
| func Eval(baseDir string, opts *options) (raw map[string]interface{}, env *v1alpha1.Config, err error) { | ||
| // Eval returns the raw evaluated Jsonnet output (without any transformations) | ||
| func Eval(baseDir string, mods ...Modifier) (raw map[string]interface{}, err error) { |
There was a problem hiding this comment.
This is even better than before, where an exported function was using an unexported type :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two flags for working with extVars:
-e/--extCode: Allows to bind any Jsonnet value (anything) to theextVar. This flag is superior to
--extVar, because it also handlesints, bools, objects and arrays. Strings need to be quoted.
--extVar: Only strings, but takes them unqouted. Added forcompatibility reasons to
jsonnet.Fixes #168 and Closes #171