fix: Stable environment name #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the name of the internally used Environment type was different depending on the argument passed on the command line, even though it resulted in the same environment after all (relative vs absolute paths, etc.) This fixes the issue by using the `jpath` package to compute baseDir and rootDir, using the relative path from rootDir to baseDir as the name. This results in stable names, regardless which directory representation is used.
All of our current commands take environments, only the import analysis works on plain files ... this has no benefit, it actually makes the implementation harder, as we cannot use stable paths there. Switches to environments as the target.
sh0rez
added
component/kubernetes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks commits cbc2c66 and 8012c65 from #131, because they are a needed enhancement but the other PR is not going to be merged soon