Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonnet): Environment vendor #198

Merged
merged 2 commits into from
Feb 9, 2020
Merged

feat(jsonnet): Environment vendor #198

merged 2 commits into from
Feb 9, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Feb 8, 2020

Introduces tkrc.yaml as an alternative project root marker to allow jsonnetfile.json per environment.

Also adds proper docs how to use this new environment local vendor feature.

Fixes #197

Adds new root marker (`tkrc.yaml`) alongside `jsonnetfile.json` to be
able to mark the actual project root when environment-local vendoring is used.
@sh0rez sh0rez added kind/feature Something new should be added component/jsonnet Everything regarding the jsonnet language labels Feb 8, 2020
@sh0rez sh0rez self-assigned this Feb 8, 2020
@sh0rez
Copy link
Member Author

sh0rez commented Feb 8, 2020

Also adds a test for making sure rootDir and baseDir are properly found

@slim-bean
Copy link
Contributor

I think we should also update tk init to create tkrc.yml

WDYT @sh0rez ??

@sh0rez
Copy link
Member Author

sh0rez commented Feb 9, 2020

I think we should also update tk init to create tkrc.yml

WDYT @sh0rez ??

Unsure about this one. jsonnetfile.json works fine as a root marker and I imagine it confusing to introduce tkrc.yaml in new projects, a totally useless file users will wonder about until they require this kind advanced feature.

I'd prefer having this totally non-breaking (and without any noticeable differences), until somebody wants to use this very feature

@slim-bean
Copy link
Contributor

I think I would vote to just have tk init create this file as it will start to ensure it's existing for everyone moving forward and I think in the long run ease confusion. But that being said I don't have a very strong opinion on this, I just want to see it merged as I'm very excited to use it :)

@sh0rez sh0rez merged commit 9fbdfe7 into master Feb 9, 2020
@sh0rez sh0rez deleted the environment-vendor branch February 9, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/jsonnet Everything regarding the jsonnet language kind/feature Something new should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override vendor per environment
2 participants