Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): fetch tags first #201

Merged
merged 1 commit into from
Feb 10, 2020
Merged

fix(release): fetch tags first #201

merged 1 commit into from
Feb 10, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Feb 10, 2020 •
edited
Loading

Fetches tags in the release pipeline so the versions reported by tk --version are actually semvers, not commit hashes

Also bumps the go version go 1.13

@sh0rez
fix(release): fetch tags first
d601c55 
Fetches tags in the release pipeline so the versions reported by `tk
--version` are actually semvers, not commit hashes
trotttrotttrott
trotttrotttrott approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@sh0rez sh0rez merged commit 67031a2 into master Feb 10, 2020
@sh0rez sh0rez deleted the release-fetch-tags branch February 10, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trotttrotttrott trotttrotttrott trotttrotttrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh0rez @trotttrotttrott