fix(kubernetes): handle kubectl-diff exit 1 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
added
kind/bug
sh0rez
force-pushed
the
diff-exit-status
branch
from
7a7da23
to
93053d7
Compare
Properly handles `exit status 1` as a result from `kubectl diff`, being aware of differences between `kubectl` versions: * Before 1.18: * 0: no error, no diff * 1: error or diff * After 1.18 (kubernetes/kubernetes#87437): * 0: no error, no diff * 1: diff * >1: error
mplzik
reviewed
Feb 13, 2020
| } | ||
|
|
||
| // before 1.18 "exit status 1" meant error as well ... so we need to check stderr | ||
| if version.LessThan(semver.MustParse("1.18.0")) && stderr != "" { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handles
exit status 1as a result fromkubectl diff,being aware of differences between
kubectlversions:1.18:0: no error, no diff1: error or diff0: no error, no diff1: diff>1: errorFixes #204
Fixes #205