Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for compatibility with windows style path environment variable. #242

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fixes for compatibility with windows style path environment variable. #242

merged 2 commits into from
Mar 18, 2020

Conversation

captncraig
Copy link
Contributor

Don't call kubectl at all until after we drop the kubeconfig patch.

And use the correct os specific path separator.

@sh0rez sh0rez self-assigned this Mar 18, 2020
@sh0rez sh0rez added the kind/bug Something isn't working label Mar 18, 2020
sh0rez
sh0rez approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sh0rez sh0rez merged commit 88a6791 into master Mar 18, 2020
@sh0rez sh0rez deleted the winfix branch March 18, 2020 20:39
@vlcinsky vlcinsky mentioned this pull request May 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez approved these changes

Assignees

@sh0rez sh0rez

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captncraig @sh0rez