Sort kubernetes objects before applying. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just applying namespces before everything else, let's sort all the objects. There's more inter-dependences between various kinds, e.g. CRDs need to be applied before the actual custom resources, StorageClasses before the PVCs, ... . Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
|
This looks good, though I wonder if it would fit better into It would need to be deterministic for this though:
|
As suggested in #244 (comment) , `Reconcile()` might be a better place for sorting, since we're already doing sort-of (pun intended) similar thing there. Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
sh0rez
requested changes
Mar 30, 2020
Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just applying namespces before everything else, let's sort
all the objects. There's more inter-dependences between various kinds,
e.g. CRDs need to be applied before the actual custom resources,
StorageClasses before the PVCs, ... .