Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): don't panic on failed diff #256

Merged
merged 1 commit into from
Apr 8, 2020
Merged

fix(kubernetes): don't panic on failed diff #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(kubernetes): don't panic on failed diff 
We recently made diff errors in apply non-fatal, but accidentally made
them even more fatal because it can now panic.

Added a check to avoid this
  • Loading branch information
@sh0rez
sh0rez committed Apr 8, 2020
commit 1d8dc0b6452a0178a2f6e9c20a2adfb593744f97
7 changes: 5 additions & 2 deletions pkg/tanka/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,11 @@ func Apply(baseDir string, mods ...Modifier) error {
diff = &tmp
}

b := term.Colordiff(*diff)
fmt.Print(b.String())
// in case of non-fatal error diff may be nil
if diff != nil {
b := term.Colordiff(*diff)
fmt.Print(b.String())
}

return kube.Apply(p.Resources, opts.apply)
}
Expand Down