Implement label selectors for 'tk env list' #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
reviewed
Jun 16, 2020
sh0rez
approved these changes
Jun 16, 2020
sh0rez
reviewed
Jun 17, 2020
Co-authored-by: sh0rez <me@shorez.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow more advanced selection of environments to do bulk operations on.
I am imagining some workflow like:
tk env list --l cluster=dev-eu-west --json | (jq) | (xargs) | tk exportto do operations across multiple environments at once.
This uses
k8s.io/apimachinery/pkg/labelsto parse and match labels, so it should have the exact same semantics as using -l in kubectl.One small unrelated feature I added is the ability to set
TANKA_ROOTenv var to help when running locally with a working directory outside the tanka tree. I found it very convenient.