Remove symlinks also from dependencies. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in #302 only removed symlinks from the directory path for `main.jsonnet`; this commit also modifies the code that iteratoes through all the transitive dependencies to de-symlink them. Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
sh0rez
reviewed
Jun 26, 2020
Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
malcolmholmes
approved these changes
Jun 30, 2020
sh0rez
requested changes
Jun 30, 2020
Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
sh0rez
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #302 only removed
symlinks from the directory path for
main.jsonnet; this commit alsomodifies the code that iteratoes through all the transitive dependencies
to de-symlink them.