feat: provide std.native('helmTemplate') #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/helmraiser
branch
from
ac0e746
to
67bda43
Compare
Example:
```
{
generated:
std.native('helmTemplate')(
'cert-manager',
'charts/jetstack/cert-manager',
{
values: {
installCRDs: true,
global: {
podSecurityPolicy: {
enabled: true,
useAppArmor: false,
},
},
},
flags: [
'--version=v0.13.0',
],
}
),
}
```
Duologic
force-pushed
the
duologic/helmraiser
branch
from
67bda43
to
5934a80
Compare
Duologic
changed the title
sh0rez
requested changes
Aug 12, 2020
sh0rez
added
component/jsonnet
sh0rez
requested changes
Aug 13, 2020
|
|
||
| func confToArgs(conf map[string]interface{}) ([]string, []string, error) { | ||
| var args []string | ||
| var tempFiles []string |
There was a problem hiding this comment.
You only ever add one file this this, right? No need for a slice then
There was a problem hiding this comment.
I'm optimizing for future cases where we might want to pass multiple files (it is possible to have multiple --values with helm template) and can easily extend this without having to change this elsewhere. If you don't see value in this, I'll remove it.
This was referenced Aug 13, 2020
sh0rez
requested changes
Aug 17, 2020
|
This is so cool I can't contain my excitement. I'm going to start a pr in deployment_tools that depend on this functionality and trust that it will get merged into a release in the near future. |
Even though this isn't the right naming, it is consistent with https://tanka.dev/env-vars Co-authored-by: sh0rez <me@shorez.de>
Co-authored-by: sh0rez <me@shorez.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken the same approach as to how the
helm templatecommand is build up:original PoC: grafana/jsonnet-libs#315