fix(k8s): consistent types in manifest.Manifest #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manifest.Manifest is a `map[string]interface{}`, which sticks to
what `json.Unmarshal` returns, meaning it only includes concrete values,
`[]interface{}` and `map[string]interface{}`.
In a v0.10
change (https://github.com/grafana/tanka/blob/a6d5fde5aac69dc4d66bb57d5a501e52ba60fada/pkg/kubernetes/manifest/manifest.go#L248)
I accidentally broke that, without realizing it.
Up to #312, this didn't create any issues. Now however, because we
called `Annotations` on all objects, types weren't like they should have
been.
This caused subsetdiff to miss annotations, not computing the subset on
them at all.
Fixes #318
sh0rez
added
kind/bug
malcolmholmes
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest.Manifest is a
map[string]interface{}, which sticks to whatjson.Unmarshalreturns, meaning it only includes concrete values,[]interface{}andmap[string]interface{}.In a v0.10 change I accidentally broke that, without realizing it:
tanka/pkg/kubernetes/manifest/manifest.go
Line 248 in a6d5fde
Up to #312, this didn't create any issues. Now however, because we called
Annotationson all objects, types weren't like they should have been.This caused subsetdiff to miss annotations, not computing the subset on them at all.
Fixes #318