Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tool/charts): untar #369

Merged
merged 1 commit into from
Sep 2, 2020
Merged

feat(tool/charts): untar #369

merged 1 commit into from
Sep 2, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Sep 1, 2020

Now automatically untars the downloaded Chart artifact, so git can
handle it better.

Is there a use-case for not doing this? Should it be configurable?

@sh0rez
feat(tool/charts): untar
301998b 
Now automatically untars the downloaded Chart artifact, so git can
handle it better.

Is there a use-case for not doing this? Should it be configurable?
@sh0rez sh0rez added the kind/feature Something new should be added label Sep 1, 2020
Duologic
Duologic approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, I don't see a reason to vendor binary objects.

@sh0rez sh0rez merged commit 9c425bf into master Sep 2, 2020
@sh0rez sh0rez deleted the charts-untar branch September 2, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duologic Duologic Duologic approved these changes

@malcolmholmes malcolmholmes Awaiting requested review from malcolmholmes

Assignees
No one assigned
Labels
component/tooling kind/feature Something new should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sh0rez @Duologic