Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inline Environment #403

Merged
merged 16 commits into from
Nov 26, 2020
Merged

feat: inline Environment #403

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
993c559
allow inline Environment
Duologic Oct 11, 2020
5c506a3
refactor: evalJsonnet -> eval
Duologic Oct 22, 2020
b18a386
refactor: use spec.Parse
Duologic Nov 4, 2020
ac417d3
refactor: extract Environment as k8s-like object
Duologic Nov 4, 2020
2ee1696
fix(cli): `tk env list` for inline envs
Duologic Nov 6, 2020
12ece72
fix: allow eval with err
Duologic Nov 18, 2020
943565f
s/v1alpha1.Config/v1alpha1.Environment
Duologic Nov 18, 2020
695e7a3
s/extract/extractedEnvs
Duologic Nov 18, 2020
b6ae81b
docs: update function descriptions
Duologic Nov 18, 2020
065a3e1
fix: return env names with error
Duologic Nov 20, 2020
f16c942
fix: log expected errors on eval
Duologic Nov 20, 2020
4ee8de7
fix: ensure metadata.name is set on loading an env
Duologic Nov 20, 2020
6533972
doc: remove out of place docstring
Duologic Nov 20, 2020
4f11ab2
fix: omitempty Data
Duologic Nov 20, 2020
9c30b46
conditional return values
Duologic Nov 26, 2020
52ba439
no switch inside if
Duologic Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
no switch inside if
  • Loading branch information
@Duologic
Duologic committed Nov 26, 2020
commit 52ba439e21d6790c8c4c788a8228a61c63b63792
15 changes: 7 additions & 8 deletions pkg/tanka/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,12 @@ func Show(baseDir string, opts Opts) (manifest.List, error) {
// Eval returns the raw evaluated Jsonnet output (without any transformations)
func Eval(dir string, opts Opts) (raw interface{}, err error) {
r, _, err := eval(dir, opts.JsonnetOpts)
if err != nil {
switch err.(type) {
case ErrNoEnv, ErrMultipleEnvs:
return r, err
default:
return nil, err
}
switch err.(type) {
case ErrNoEnv, ErrMultipleEnvs:
return r, err
case nil:
return r, nil
default:
return nil, err
}
return r, nil
}