fix(cli): Environment name at env creation (#397) #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment name is the relative path of an env dir. tk env add is incorrectly using the base dir name. This PR fixes it. jpath pkg is used to benefit from the existing implementation. FindRoot function is made public instead of using Resolve because Resolve does many other things as well, some of which require files that don't exist at that time. Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment name is the relative path of an env dir. tk env add is incorrectly
using the base dir name. This PR fixes it.
jpath pkg is used to benefit from the existing implementation. FindRoot function
is made public instead of using Resolve because Resolve does many other things
as well, some of which require files that don't exist at that time.
Signed-off-by: Michal Wasilewski mwasilewski@gmx.com