Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New URL for stable helm repo #425

Merged
merged 1 commit into from
Dec 4, 2020
Merged

New URL for stable helm repo #425

merged 1 commit into from
Dec 4, 2020

Conversation

malcolmholmes
Copy link
Contributor

Using our Helm integration now gives this:

WARNING: "kubernetes-charts.storage.googleapis.com" is deprecated for "stable" and will be deleted Nov. 13, 2020.
WARNING: You should switch to "https://charts.helm.sh/stable" via:
WARNING: helm repo add "stable" "https://charts.helm.sh/stable" --force-update

This PR does what they say, and prevents the warnings.

jvrplmlmn
jvrplmlmn approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/docs/helm.mdx Outdated Show resolved Hide resolved
Duologic
Duologic approved these changes Nov 23, 2020
View reviewed changes
docs/docs/helm.mdx Outdated Show resolved Hide resolved
sh0rez
sh0rez approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestion of @Duologic applied

@Duologic
Copy link
Member

Duologic commented Dec 4, 2020

Rebased this.

@Duologic Duologic merged commit 4b74e67 into master Dec 4, 2020
@Duologic Duologic deleted the new-helm-url branch December 4, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvrplmlmn jvrplmlmn jvrplmlmn approved these changes

@Duologic Duologic Duologic approved these changes

@sh0rez sh0rez sh0rez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malcolmholmes @Duologic @jvrplmlmn @sh0rez